Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider empty subfolder as None in hf_hub_url and hf_hub_download #1021

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Aug 31, 2022

Fix #1016.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 31, 2022

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1021 (792a81b) into main (48ddc62) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   82.16%   82.18%   +0.01%     
==========================================
  Files          35       35              
  Lines        3588     3592       +4     
==========================================
+ Hits         2948     2952       +4     
  Misses        640      640              
Impacted Files Coverage Δ
src/huggingface_hub/file_download.py 85.79% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Wauplin Wauplin merged commit 4af799e into main Aug 31, 2022
@Wauplin Wauplin deleted the 1016-fix-hf-hub-download-with-empty-subfolder branch August 31, 2022 10:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace empty subfolder with None in hf_hub_download
3 participants