Remove repo_id validation in hf_hub_url and hf_hub_download #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Sep 5, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sgugger Sorry I realized I merged #1029 without removing the validation for
hf_hub_urlandhf_hub_download. Asrepo_id="datasets/.../..."is used intransformersI guess it's better to remove the validation for now untiltransformersis updated. Since I'm not exactly sure how critical/problematic this is, I let you tell me what you prefer to do. I can also put a warning message for wrong usage if you think it's not damaging the user experience.My only concern is that we set validation back whenever possible and at most in a few releases (v0.12 ?). Your call :)
(cc @LysandreJik also)
Related: #1008, #1029 (comment) and #1029 (comment)