Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

👽️ Add size parameter for lfsFiles when committing on the hub #1048

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

coyotte508
Copy link
Member

No description provided.

@coyotte508 coyotte508 linked an issue Sep 14, 2022 that may be closed by this pull request
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 14, 2022

The documentation is not available anymore as the PR was closed or merged.

@coyotte508
Copy link
Member Author

@Wauplin sorry I don't understand by the coverage decreased so much 🤯

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for taking care of it :)

About code coverage, the check is updated each time one of the tests is finished. So for the first minutes it's really low since only a few tests are finished. The coverage is reliable only once all checks have passed which is the case now !

@coyotte508 coyotte508 merged commit b60bdd6 into main Sep 14, 2022
@coyotte508 coyotte508 deleted the 1047-add-size-parameter-for-lfsfiles-for-commit-api branch September 14, 2022 12:39
@Pierrci
Copy link
Member

Pierrci commented Sep 14, 2022

Thanks @coyotte508 @Wauplin!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "size" parameter for lfsFiles for commit API
4 participants