Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix default cache on windows #1069

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Fix default cache on windows #1069

merged 3 commits into from
Sep 21, 2022

Conversation

thomwolf
Copy link
Member

Hard-coding the default cache lead to a broken path with slash on Windows

Fix huggingface/simulate#217

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 20, 2022

The documentation is not available anymore as the PR was closed or merged.

@thomwolf thomwolf force-pushed the fix-default-cache-windows branch from e075f1c to 733cecc Compare September 20, 2022 22:55
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 84.19% // Head: 84.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (355727b) compared to base (15d0f5d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   84.19%   84.20%           
=======================================
  Files          38       38           
  Lines        4120     4121    +1     
=======================================
+ Hits         3469     3470    +1     
  Misses        651      651           
Impacted Files Coverage Δ
src/huggingface_hub/repocard.py 94.44% <ø> (ø)
src/huggingface_hub/constants.py 90.69% <100.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wauplin
Copy link
Contributor

Wauplin commented Sep 21, 2022

Thanks @thomwolf for the fix. I updated the code to expand "~" as well (it can have weird effect if Path(...).resolve() is used somewhere in the code). Will merge as soon as the CI passes :)

@Wauplin Wauplin merged commit d3efd1e into main Sep 21, 2022
@Wauplin Wauplin deleted the fix-default-cache-windows branch September 21, 2022 08:49
@thomwolf
Copy link
Member Author

Awesome thanks, any idea of when the next release is expected to be?

@Wauplin
Copy link
Contributor

Wauplin commented Sep 21, 2022

@thomwolf is "soon" a good enough answer ? :D

(more pragmatically, I'd say hopefully next week)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading from hub not working
3 participants