Check symlinks support per directory instead of globally #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Codecov ReportBase: 84.36% // Head: 84.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
+ Coverage 84.36% 84.68% +0.32%
==========================================
Files 40 38 -2
Lines 4100 3925 -175
==========================================
- Hits 3459 3324 -135
+ Misses 641 601 -40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
LysandreJik
approved these changes
Sep 23, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1062 (comment).
Issue is that we were checking the support of symlinks globally (in
/tmp) instead of a per-folder check. This can be an used if the cache dir and the tmp dir are mounted on different volumes with different rules. This implementation should not be safer.Also, warning message is displayed once per cache dir in use. In a vast majority of cases this means once per runtime since cache directory usually don't change.