Commit empty files as regular and warn user #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Codecov ReportBase: 83.93% // Head: 84.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 83.93% 84.02% +0.09%
==========================================
Files 43 43
Lines 4282 4288 +6
==========================================
+ Hits 3594 3603 +9
+ Misses 688 685 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adrinjalali
approved these changes
Nov 10, 2022
julien-c
reviewed
Nov 15, 2022
| if not path.endswith(".gitkeep"): | ||
| warnings.warn( | ||
| f"About to commit an empty file: '{path}'. Are you sure this is" | ||
| " intended ?" |
julien-c
reviewed
Nov 15, 2022
| for addition in additions: | ||
| if addition.upload_info.size == 0: | ||
| path = addition.path_in_repo | ||
| if not path.endswith(".gitkeep"): |
There was a problem hiding this comment.
maybe extend to all filenames that start with a dot?
(nit) i dont think it's that uncommon to have empty files
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #946.
With this PR:
skopsanymore - except if you want a more detailed message).gitkeepfiles (legit use case)(cc @SBrandeis who created in issue)