Fix get file size on lfs #1188
Merged
Fix get file size on lfs #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
looks great!
also cc @coyotte508 for the linked-size header
|
The documentation is not available anymore as the PR was closed or merged. |
coyotte508
approved these changes
Nov 15, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes an issue in
get_hf_file_metadata.In case of LFS file,
sizewas set to the pointer file size, not the actual LFS file itself.Also few nits from @julien-c 's reviews.