Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add sklearn code snippet #133

Merged
merged 6 commits into from
Jun 29, 2021
Merged

Add sklearn code snippet #133

merged 6 commits into from
Jun 29, 2021

Conversation

osanseviero
Copy link
Contributor

@osanseviero osanseviero commented Jun 22, 2021 •
edited
Loading

Screen Shot 2021-06-24 at 8 41 02 AM

@osanseviero osanseviero requested a review from julien-c June 22, 2021 07:49
julien-c
julien-c reviewed Jun 22, 2021
View reviewed changes
interfaces/Libraries.ts Outdated Show resolved Hide resolved
@julien-c
Copy link
Member

Also this screenshot makes me think that maybe we need/want a hf_hub_download(...) method which does cached_download(hf_hub_url())

cc @LysandreJik

@LysandreJik
Copy link
Member

Yeah that sounds great! I'll open a PR in a bit.

@osanseviero osanseviero requested a review from julien-c June 24, 2021 06:43
@osanseviero
Copy link
Contributor Author

Friendly ping :)

@julien-c
Copy link
Member

LGTM!

@osanseviero osanseviero merged commit a2dd1ef into main Jun 29, 2021
@osanseviero osanseviero deleted the sklearn_snippet branch June 29, 2021 15:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@julien-c julien-c julien-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osanseviero @julien-c @LysandreJik