More robust endpoint with toggled staging endpoint #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
force-pushed
the
staging-endpoint-in-var
branch
from
7cd9283 to
e908a5a
Compare
LysandreJik
commented
Jun 30, 2021
| @@ -51,6 +52,7 @@ | |||
| DATASET_SAMPLE_PY_FILE = "custom_squad.py" | |||
|
|
|||
|
|
|||
| @with_production_testing | |||
There was a problem hiding this comment.
This decorator enables running test on the hf.co endpoint rather than the moon-staging endpoint. I think it's good practice to explicitly opt-in for production testing
tests/test_repository.py
Outdated
| clone_from=f"{ENDPOINT_STAGING}/valid_org/{REPO_NAME}", | ||
| clone_from=f"valid_org/{REPO_NAME}", |
There was a problem hiding this comment.
These cases can now be tested!
This was referenced Jun 30, 2021
julien-c
reviewed
Jun 30, 2021
Comment on lines
+24
to
26
| ENDPOINT = ( | ||
| "https://moon-staging.huggingface.co" if _staging_mode else "https://huggingface.co" | ||
| ) |
There was a problem hiding this comment.
the CI env var itself could be the endpoint https://moon-staging.huggingface.co which would be neat b/c then this doesn't appear in the code
* Allow passing only model ID to clone when authenticated * Enable dataset repositories (#151) * Enable dataset repositories * Address Julien's review * Better API
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the default endpoint to use the moon-landing endpoint when the
HUGGINGFACE_CO_STAGINGenvironment variable is set.Doing this enables testing for HF Hub IDs without needing to specify the moon-landing endpoint explicitly, in turn adding coverage for the user/organization and model ID identification.