Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing keras outputs (widgets was ignoring because of type mismatch, now testing for it) #176

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Fixing keras outputs (widgets was ignoring because of type mismatch, now testing for it) #176

merged 2 commits into from
Jul 9, 2021

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Jul 8, 2021

No description provided.

@Narsil Narsil requested a review from osanseviero July 8, 2021 16:14
osanseviero
osanseviero approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's also change https://github.com/huggingface/huggingface_hub/blob/main/api-inference-community/docker_images/timm/tests/test_api_image_classification.py so this does not slip away.

@osanseviero
Copy link
Contributor

And thanks for sending the PR :)

@Narsil Narsil merged commit d373437 into main Jul 9, 2021
@Narsil Narsil deleted the fixing_image_classification_keras branch July 9, 2021 07:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Narsil @osanseviero