Fix: correctly encode/decode config in ModelHubMixin if custom coders #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
not-lain
suggested changes
Jun 14, 2024
| provided_config = passed_values.get("config") | ||
| if isinstance(provided_config, dict): | ||
| init_config.update(provided_config) | ||
| if isinstance(passed_config, dict): |
There was a problem hiding this comment.
we should change this one, a counter-example would be
class Model(nn.Module,PyTorchModelHubMixin):
def __init__(self,config):
super().__init__()
# other stuff here maybe load config file number 2
self.layer = nn.Linear(config,config)
model = Model(2)
model._hub_mixin_config>>> None
There was a problem hiding this comment.
Hmm, I'd prefer not to update the lib' for this corner case. This PR is meant to fix real-world issue (reported by @NielsRogge for https://github.com/hamadichihaoui/BIRD/) but having a int config seems pretty unusual.
Co-authored-by: Hafedh <70411813+not-lain@users.noreply.github.com>
LysandreJik
approved these changes
Jun 14, 2024
|
Thanks both for the quick review! 🤗 |
Wauplin
added a commit
that referenced
this pull request
Jun 14, 2024
…#2337) * Fix: correctly encode/decode config in ModelHubMixin if custom coders * make style * make quality * Update tests/test_hub_mixin_pytorch.py Co-authored-by: Hafedh <70411813+not-lain@users.noreply.github.com> --------- Co-authored-by: Hafedh <70411813+not-lain@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2334.
Thanks to @not-lain's investigation (see #2334 (comment)), I have been able to reproduce the error with a simple example. The problem was that custom encoders/decoders were not used for the special attribute
config. This PR fixes it. I also added a regression test inspired by the reproducible example.Once merged, I'll make a hot-fix release with this fix.
(failing tests are unrelated)