Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add inferenceStatus to ExpandModelProperty_T type #2388

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jul 11, 2024

This is needed when the expand parameter is extended server-side. It doesn't affect client-side logic but helps with autocompletion + docs. cc @SBrandeis who recently shipped inferenceStatus.

@Wauplin Wauplin requested review from LysandreJik and SBrandeis July 11, 2024 17:25
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin Wauplin merged commit 982f9a2 into main Jul 12, 2024
17 checks passed
@Wauplin Wauplin deleted the fix-expand-param-models branch July 12, 2024 06:34
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that the prop name might change (possibly) cc @SBrandeis

@SBrandeis
Copy link
Contributor

@Wauplin parameter has changed to inference recently
Values have changed as well (and might change again in the future)

@Wauplin
Copy link
Contributor Author

Wauplin commented Jul 29, 2024

Thanks for the heads-up @SBrandeis! I've updated this in c8a3e3a (sry, no PR 🙈)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants