Add scale_to_zero_timeout parameter to HFApi.create/update_inference_endpoint #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Awesome! Thanks @hommayushi3 for the clean PR. Adding this parameters makes perfect sense yes. I'll merge this PR as soon as the CI passes.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Failing tests in the CI are unrelated so time to merge! |
|
thanks a lot for this PR @hommayushi3! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to pass a "scale_to_zero_timeout" to both
create_inference_endpointandupdate_inference_endpointon HFApi. Addresses #2462.