Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[HfApi] update list of repository properties following server side updates #2728

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

hanouticelina
Copy link
Contributor

Fixes the failing tests.
following moon-landing#11757 and moon-landing#12004 (private links) which add new repositories properties: usedStorage and resourceGroup, this PR aligns the list of the different repo types (models, datasets and spaces) properties and update the docstrings accordingly.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Kakulukian Kakulukian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hanouticelina
Copy link
Contributor Author

thanks for the reviews!

@hanouticelina hanouticelina merged commit 126aded into main Jan 6, 2025
17 checks passed
@hanouticelina hanouticelina deleted the update-dataset-property branch January 6, 2025 10:24
Comment on lines +161 to +162
"usedStorage",
"resourceGroup",
Copy link
Contributor

@Wauplin Wauplin Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) so far I've tried to keep alphabetical order in this list + docstrings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, did not catch the alphabetical order! I'll update that in another PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants