Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix conda by specifying python version + add tests to main branch #28

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Fix conda by specifying python version + add tests to main branch #28

merged 1 commit into from
Apr 8, 2021

Conversation

LysandreJik
Copy link
Member

This PR fixes two things:

  • The anaconda upload fails because it lacks support for python 3.9, while python 3.9 is the default conda installation. This PR sets python 3.8 as the default
  • The current CI doesn't run on main

@LysandreJik LysandreJik requested a review from julien-c April 8, 2021 22:07
julien-c
julien-c approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LysandreJik LysandreJik merged commit 5f94575 into huggingface:main Apr 8, 2021
@LysandreJik LysandreJik deleted the fix-ci branch April 8, 2021 22:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@julien-c julien-c julien-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LysandreJik @julien-c