Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Last fixes for datasets' push_to_hub method #415

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

LysandreJik
Copy link
Member

This PR implements a few fixes necessary to have the datasets' push_to_hub method implemented:

  • The regex for filenames that can be pushed to the hub does not allow the use of the - symbol which is necessary for files in the format <split_name>-00001-of-00010
  • The list_repo_files actually only works for models. This adds support for datasets, and a future PR should also enable spaces.

Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@LysandreJik LysandreJik merged commit e701af7 into main Oct 29, 2021
@LysandreJik LysandreJik deleted the dataset-push-to-hub branch October 29, 2021 13:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants