New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

clean_ok should be True by default #462

Merged

LysandreJik merged 1 commit into main from clean_ok_true_by_default

Nov 8, 2021

Member

LysandreJik commented Nov 8, 2021

Should default to True so that two consecutive push_to_hub do not end up failing. Will greatly reduce friction in examples/downstream usage.


          clean_ok should be True by default

fd89a53

LysandreJik requested a review from sgugger

November 8, 2021 17:41

sgugger approved these changes

View reviewed changes

Contributor

sgugger left a comment

Yes, thanks a lot for this fix!

LysandreJik merged commit 66c8010 into main

LysandreJik deleted the clean_ok_true_by_default branch

November 8, 2021 18:55

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet