Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update fairseq TTS pipeline #569

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Conversation

kahne
Copy link
Contributor

@kahne kahne commented Jan 4, 2022

No description provided.

@kahne kahne marked this pull request as ready for review January 4, 2022 17:52
@osanseviero
Copy link
Contributor

osanseviero commented Jan 5, 2022

Thank you very much for this PR!

This seems to have a couple of issues as seen in the Docker tests during installation of requirement (pkuseg). I was not able to reproduce unfortunately, maybe @Narsil has some ideas otherwise I can dive a bit more into this.

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, thanks @Narsil and @kahne!

@Narsil
Copy link
Contributor

Narsil commented Jan 5, 2022

It seems the issue lies in the pkuseg that requires numpy to already be installed as it uses it in its installation script.

I took the liberty of modifying
self.generator = self.task.build_generator(self.model, cfg) into self.generator = self.task.build_generator(model, cfg) (first is the raw model, second is a model list)

Also adding another layer of protection against bogus data ("\x00\x00" as an input gets transformed into nil tensor which triggers and error).

@Narsil Narsil merged commit 1f83ed2 into huggingface:main Jan 5, 2022
@kahne kahne deleted the update_fairseq_tts branch January 7, 2022 16:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants