Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

spaCy code snippet and language tag #57

Merged
merged 6 commits into from
May 31, 2021
Merged

spaCy code snippet and language tag #57

merged 6 commits into from
May 31, 2021

Conversation

osanseviero
Copy link
Contributor

@osanseviero osanseviero commented May 27, 2021

Here is how it would look like.

@ines FYI

Screen Shot 2021-05-27 at 8 26 01 PM

@osanseviero osanseviero changed the title Spacy code snippet and language tag spaCy code snippet and language tag May 27, 2021
@osanseviero osanseviero requested a review from LysandreJik May 28, 2021 06:47
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something, but from what I'm seeing currently the version is in the wheel name? For example: xxx_sm-3.0.0-py3-none-any.whl

I don't think that works with the URL you crafted here:

# pip install https://huggingface.co/${model.modelId}/resolve/main/${nameWithoutNamespace(model.modelId)}.whl<br class="Apple-interchange-newline">

@osanseviero
Copy link
Contributor Author

I might be missing something, but from what I'm seeing currently the version is in the wheel name? For example: xxx_sm-3.0.0-py3-none-any.whl

I don't think that works with the URL you crafted here:

# pip install https://huggingface.co/${model.modelId}/resolve/main/${nameWithoutNamespace(model.modelId)}.whl<br class="Apple-interchange-newline">

Yes, the version should not be in the wheel name and is something I need to update from the script that updates the repos.

@osanseviero osanseviero requested a review from LysandreJik May 28, 2021 10:01
@osanseviero
Copy link
Contributor Author

I changed the name of the .whl file and it should work now. The script is updating the repos now.
Here is an example: https://huggingface.co/spacy/xx_sent_ud_sm.

@julien-c
Copy link
Member

that looks super cool! 😍

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @osanseviero!

@osanseviero osanseviero merged commit 4045445 into main May 31, 2021
@osanseviero osanseviero deleted the spacy branch May 31, 2021 07:54
interfaces/Libraries.ts Show resolved Hide resolved
interfaces/Libraries.ts Show resolved Hide resolved
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants