Bring consistency to download and upload APIs #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@osanseviero mostly interested on if you think I missed any. There weren't many instances of this happening from a user perspective I could see, but one may have trickled past me |
osanseviero
reviewed
Jan 4, 2022
LysandreJik
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
Agree with @osanseviero's comment, otherwise this looks good!
osanseviero
approved these changes
Jan 5, 2022
|
Based on advice from @LysandreJik I forgo that logic for a complete refactor, making use of the |
LysandreJik
approved these changes
Jan 5, 2022
Comment on lines
+817
to
+820
| raise ValueError( | ||
| f"""Passed `organization` and `name` organization are not the same ({organization}, {checked_name[1]}). | ||
| Please either include the organization in only `name` or the `organization` parameter, such as `api.create_repo({checked_name[0]}, organization={organization})` or `api.create_repo({checked_name[1]}/{checked_name[2]})`""" | ||
| ) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47
This PR aims to bring some consistency in how the api can be used, by letting a user both pass in a specified
organizationas well as usingorganization/model_namefor functions revolving around uploading and downloading