Add section on malware scanning #583
Conversation
|  | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
maybe even link to that dummy sample repo here?
|
|
||
|  | ||
|
|
||
| _Note_: if your file has neither an ok or infected badge, it could mean that it is either currently being scanned / waiting to be scanned or that there was an error during the scan. It can take up to a few minutes to be scanned. |
There was a problem hiding this comment.
Unrelated to this PR, but should we also show a big warning in https://huggingface.co/mcpotato/42-eicar-street when a repo has infected files?
There was a problem hiding this comment.
It's kind of there already, just on the files tab
There was a problem hiding this comment.
I don't think it's the same. As a user of a model, I would likely not open the files tab, just read the model card and even click the "how to clone" button in the model card to download the model. If a model is scanned to be unsafe, we should show it more prominently imo. (happy to follow up discussing this in slack :D)
There was a problem hiding this comment.
Yes we can definitely add this to the main repo page as well (cc @gary149)
maybe you can add a PR to do that at some point @McPatate (no huge rush IMO, given that no repo is currently infected)
The only drawback i see is an extra http call for each repo page load => maybe we want to cache a list of "infected repos" in the DB then (and move to a slightly more stateful design)
Thoughts?
There was a problem hiding this comment.
I've just made it so that calls to my API take on avg 5-10 ms. Is that too much of an overhead ?
|
Ok for me to merge this! (and deploy on hf.co) |
No description provided.