Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix AllenNLP QA example #80

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Conversation

epwalsh
Copy link
Contributor

@epwalsh epwalsh commented Jun 7, 2021

No description provided.

@LysandreJik
Copy link
Member

Thanks @epwalsh!

@LysandreJik LysandreJik requested a review from osanseviero June 7, 2021 16:12
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @epwalsh!

I think the same bug might be in the Inference API. If possible, could you update the code in the docker image (just this line)? If not, we're happy to send a follow-up PR

@LysandreJik
Copy link
Member

The inference-api will also need to be updated to use a more recent version of AllenNLP; right now it's using an old fork of mine (hence why it works without the hf://), it should probably just use the latest version available and pin it. It's done in the AllenNLP requirements: https://github.com/huggingface/huggingface_hub/blob/main/api-inference-community/docker_images/allennlp/requirements.txt

cc @Narsil

@epwalsh
Copy link
Contributor Author

epwalsh commented Jun 7, 2021

@LysandreJik, thanks, I'll update that as well 👍

@osanseviero osanseviero merged commit 664a343 into huggingface:main Jun 7, 2021
@osanseviero
Copy link
Contributor

Thank you!

@epwalsh epwalsh deleted the allennlp-example branch June 7, 2021 16:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants