Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT Add pre-commit hooks #807

Merged
merged 4 commits into from
Mar 31, 2022
Merged

MNT Add pre-commit hooks #807

merged 4 commits into from
Mar 31, 2022

Conversation

adrinjalali
Copy link
Contributor

This PR adds pre-commit hooks to the repo.

These hooks are only enabled if the user installs them. By default cloning the repo will have them disabled.

Once enabled, they only run on changed files and not the whole repo which makes them quite fast.

cc @LysandreJik @osanseviero

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added a minor suggestion

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 31, 2022

The documentation is not available anymore as the PR was closed or merged.

@adrinjalali
Copy link
Contributor Author

Merging with two approvals.

@adrinjalali adrinjalali merged commit b287fba into huggingface:main Mar 31, 2022
@adrinjalali adrinjalali deleted the pre-commit branch March 31, 2022 13:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants