Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT change dev version to 0.5, 0.4 is already released #810

Merged
merged 3 commits into from
Mar 31, 2022
Merged

MNT change dev version to 0.5, 0.4 is already released #810

merged 3 commits into from
Mar 31, 2022

Conversation

adrinjalali
Copy link
Contributor

We're releasing 0.5, not 0.4.

@adrinjalali adrinjalali requested a review from LysandreJik March 31, 2022 07:04
@adrinjalali adrinjalali added this to the v0.5 milestone Mar 31, 2022
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change @adrinjalali!

@LysandreJik
Copy link
Member

Re-running the tests now that the inference-api rate limit was fixed.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@adrinjalali
Copy link
Contributor Author

self = <tests.test_hf_api.HfApiPublicTest testMethod=test_model_info_with_security>

    @with_production_testing
    def test_model_info_with_security(self):
        _api = HfApi()
        model = _api.model_info(
            repo_id=DUMMY_MODEL_ID,
            revision=DUMMY_MODEL_ID_REVISION_ONE_SPECIFIC_COMMIT,
            securityStatus=True,
        )
        self.assertEqual(
>           getattr(model, "securityStatus"),
            {"containsInfected": False, "infectionTypes": []},
        )
E       AttributeError: 'ModelInfo' object has no attribute 'securityStatus'

we've seen this before, didn't we fix it?

@adrinjalali
Copy link
Contributor Author

O changed the version to 0.5 instead of 0.5.0 since minor bugfix number is irrelevant for the purpose of people knowing when something was added or changed (I think)

@LysandreJik
Copy link
Member

LysandreJik commented Mar 31, 2022

Sounds good, LGTM. Merging!

cc @muellerzr I believe you had encountered this CI error in the past?

@LysandreJik LysandreJik merged commit c2db969 into huggingface:main Mar 31, 2022
@muellerzr
Copy link
Contributor

Yeah, it just needs to be reran (not a fan of that of course). It's an issue on the db side IIRC.

@adrinjalali adrinjalali deleted the fix/version branch March 31, 2022 12:41
@julien-c
Copy link
Member

julien-c commented Apr 2, 2022

yes i'm aware of this server-side issue (flakyness on securityStatus), I'll create an action item to address that (cc @McPatate)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants