Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT support older requests versions #817

Merged
merged 2 commits into from
Apr 4, 2022
Merged

MNT support older requests versions #817

merged 2 commits into from
Apr 4, 2022

Conversation

adrinjalali
Copy link
Contributor

I've tested locally for all possibilities of installed packages (simplejson, json, old and new requests).

I don't think we need to add CI to test for old requests though.

Fixes #816

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 4, 2022

The documentation is not available anymore as the PR was closed or merged.

@adrinjalali adrinjalali requested a review from LysandreJik April 4, 2022 12:03
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort, @adrinjalali!

@LysandreJik LysandreJik merged commit 912078f into huggingface:main Apr 4, 2022
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@adrinjalali adrinjalali deleted the requests branch April 5, 2022 08:51
@adrinjalali adrinjalali changed the title MNT support oder requests versions MNT support older requests versions May 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax version constraint on requests
4 participants