Add skip_lfs_files to mixins' push_to_hub #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Just to see if I understand correctly, this will make the pulling within the |
|
A bit unrelated to this PR, but it would be nice to change repo.git_add()
repo.git_commit(commit_message)
repo.git_push()to repo.push_to_hub() |
adrinjalali
approved these changes
Apr 29, 2022
|
@osanseviero I kinda do appreciate the methods being explicit about whether they do git or they work with the REST endpoints. |
LysandreJik
approved these changes
Apr 29, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know #847 is going to change a lot with the mixins, but this is a really helpful simple change that we leveraged in the HugGAN sprint that I figured we could add for now. Its nice to be able to skip LFS files when you're using a temp dir as your save dir (which you might be doing in a for loop, such as a training loop).