Constant was accidentally removed during deprecation transition #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
@LysandreJik I can't account for why the coverage checks would fail. The test clearly covers the bug that we are fixing here. Any thoughts? |
osanseviero
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
This PR Looks good! Thanks for the fix! 🔥
Note that when importing from snapshot_download you get the following warning:
/home/osanseviero/miniconda3/lib/python3.9/site-packages/huggingface_hub/snapshot_download.py:6: FutureWarning: snapshot_download.py has been made private and will no longer be available from version 0.11. Please use `from huggingface_hub import snapshot_download` to import the only public function in this module.
so by version 0.11 this variable will be removed. sentence-transformers should likely also pin the version of huggingface_hub it's using.
osanseviero
pushed a commit
that referenced
this pull request
Jun 17, 2022
Co-authored-by: Lyle Nel <lyle@owlin.com>
TristanThrush
pushed a commit
that referenced
this pull request
Jun 19, 2022
Co-authored-by: Lyle Nel <lyle@owlin.com>
adrinjalali
pushed a commit
that referenced
this pull request
Jun 21, 2022
* added autoeval fields to repocard types * modified test, linted * Fix typo (#902) * Refine 404 errors (#878) * Add errors * Style * Review * hf_hub_download support * Errors for hf_hub_download * Typo * Handle 401 error * Tests for 401 error * Typo * Review comments * added documentation for the repocard change in repocard, updated metadata_eval_result, added documentation * 🏗 Use `hub-ci` for tests (#898) * 🏗 Use `hub-ci` for tests cc @XciD * 🩹 Also update URL for staging mode * ✅ 401 is raised when the user is not authenticated * 🗑 Deprecare `identical_ok` * Longer deprecation period * ✅ Fix the last failing test * Warning match docstring * FIX Avoid creating repository when it exists on remote (#900) * fix for spaces * fix for spaces * removed creating repository and added warning * revert my changes * added tests * removed debugger 😐 * fixed repository removal * Added tests and error * import pytest * fixed tests * fixed tests * style * removed repo removal * make style * fixed test with Lysandres patch * added fix * Remove deprecations (#910) * Remove deprecations * Typo * Update src/huggingface_hub/README.md Co-authored-by: Julien Chaumond <julien@huggingface.co> Co-authored-by: Julien Chaumond <julien@huggingface.co> * Add request ID to all requests (#909) * Add request ID to all requests * Typo * Typo * Review comments * Update src/huggingface_hub/utils/_errors.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Invert deprecation for create_repo (#912) * Invert deprecation for create_repo * Set to 0.10 * Constant was accidentally removed during deprecation transition (#913) Co-authored-by: Lyle Nel <lyle@owlin.com> * Update src/huggingface_hub/repocard_types.py Co-authored-by: lewtun <lewis.c.tunstall@gmail.com> * Update repocard_types.py * Update repocard_types.py * reorded metadata_eval_request_docs, added metrics_config and metrics_verified to tests Co-authored-by: lsb <leebutterman@gmail.com> Co-authored-by: Lysandre Debut <lysandre.debut@reseau.eseo.fr> Co-authored-by: Simon Brandeis <33657802+SBrandeis@users.noreply.github.com> Co-authored-by: Merve Noyan <merveenoyan@gmail.com> Co-authored-by: Julien Chaumond <julien@huggingface.co> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> Co-authored-by: Lyle Nel <lyle-nel@users.noreply.github.com> Co-authored-by: Lyle Nel <lyle@owlin.com> Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constant was available before the deprecation notice, so it should be available during the warning transition period.
Note that the sentence-transformers library makes use of this constant link to code