🐛 Fix PR creation for a repo the user does not own #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
coyotte508
approved these changes
Jun 22, 2022
osanseviero
reviewed
Jun 22, 2022
SBrandeis
force-pushed
the
fix-pr-creation
branch
from
26b2337 to
1a8b4e6
Compare
LysandreJik
approved these changes
Jun 29, 2022
osanseviero
approved these changes
Jun 29, 2022
Wauplin
approved these changes
Aug 5, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug preventing anyone to create a Pull Request with
upload_file. This bug has two parts:fetch_upload_modes(pre-upload call) was missing the?create_pr=1query parameter when requesting the pre-upload edpoint, resulting in a 403 HTTP errorpost_lfs_batch_infowould specifybody.ref.namewhenrevisionis passed, resulting in an HTTPError 403 when trying to open a PRThis pull request addresses those two points
cc: @lewtun @abhishekkrthakur
cc @coyotte508 : not sure
?create_pr=1should be required for the pre-upload endpoint, wdyt?