Fix custom handling of refined HTTPError

[osanseviero]

As discussed internally, #878 introduced a backwards compatibility issue as it does not contain all the information from the original error (such as the status_code), which was being used in downstream libraries such as speechbrain.

This PR changes the error handling to re-use the original error but with additional custom message. To avoid this situation happening again, also introducing some tests.

[HuggingFaceDocBuilderDev]

The documentation is not available anymore as the PR was closed or merged.

[osanseviero]

This was causing issues. The existing fix would raise an error such as

huggingface_hub.utils._errors.RepositoryNotFoundError: 404 Client Error: Repository Not Found for url: https://huggingface.co/api/models/efwfwefw. If the repo is private, make sure you are authenticated. (Request ID: ktudRx2-3fp48WpTK6013)

but the e.response.text is still Repository not found. On the other hand with _raise_for_status(r) there is no need anymore to capture the type of error.

[osanseviero]

Still to be figured would be this though

try:
   model_info("efwfwefw")
except RepositoryNotFoundError as e:
   print(e.response.text)

{"error":"Repository not found"}

but

model_info("efwfwefw")

correctly gives

huggingface_hub.utils._errors.RepositoryNotFoundError: 404 Client Error: Repository Not Found for url: https://huggingface.co/api/models/efwfwefw. If the repo is private, make sure you are authenticated. (Request ID: WJtGL2IulzooY9JLwHEBn)

[osanseviero]

I did a second pass removing _raise_with_request_id and doing some cleanup/refactoring.

[osanseviero]

At the end of _raise_for_status as a fallback if there is no error in the response header's, it raises the usual HTTPError with the addition of the request ID. For example:

  File "/home/osanseviero/Desktop/workspace/huggingface_hub/test.py", line 5, in <module>
    HfApi().get_model_tags()
  File "/home/osanseviero/miniconda3/envs/huggingface_hub/lib/python3.9/site-packages/huggingface_hub/hf_api.py", line 677, in get_model_tags
    _raise_for_status(r)
  File "/home/osanseviero/miniconda3/envs/huggingface_hub/lib/python3.9/site-packages/huggingface_hub/utils/_errors.py", line 107, in _raise_for_status
    raise e
  File "/home/osanseviero/miniconda3/envs/huggingface_hub/lib/python3.9/site-packages/huggingface_hub/utils/_errors.py", line 70, in _raise_for_status
    response.raise_for_status()
  File "/home/osanseviero/miniconda3/envs/huggingface_hub/lib/python3.9/site-packages/requests/models.py", line 960, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://huggingface.co/api/models-tags-by-typee (Request ID: IPaFZ_WCu1fOsmaavFXFX)

[LysandreJik]

This is very nice, thanks for working on it @osanseviero! Appreciate the work on the tests as well.

[osanseviero]

Feel free to merge if you think this looks good 😄 quality is unrelated (#934)

[LysandreJik]

Thanks for your work, @osanseviero!