[Doc] Update "Download files from the Hub" doc #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
requested review from
adrinjalali,
osanseviero,
LysandreJik,
SBrandeis and
stevhliu
|
The documentation is not available anymore as the PR was closed or merged. |
stevhliu
approved these changes
Jul 20, 2022
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
osanseviero
approved these changes
Jul 22, 2022
| @@ -4,8 +4,6 @@ | |||
|
|
|||
| [[autodoc]] huggingface_hub.snapshot_download | |||
|
|
|||
| [[autodoc]] huggingface_hub.cached_download | |||
There was a problem hiding this comment.
Why are we removing this?
There was a problem hiding this comment.
It's deprecated so I wouldn't promote the method in the package reference anymore.
Do you feel strongly otherwise?
julien-c
commented
Jul 26, 2022
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
Co-authored-by: Simon Brandeis <33657802+SBrandeis@users.noreply.github.com>
|
Ok, this seems to be in good shape, I'll merge it soon and we can always iterate in later PRs. Also tagging @Wauplin for review when he joins=) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is not promote the deprecated
cached_downloadanymore, and instead focus primarily onhf_hub_download