Enable flake8-bugbear + adapt existing codebase
#967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Wauplin
commented
Aug 5, 2022
Wauplin
commented
Aug 5, 2022
LysandreJik
approved these changes
Aug 8, 2022
osanseviero
approved these changes
Aug 8, 2022
Co-authored-by: Lysandre Debut <hi@lysand.re>
This was referenced Aug 9, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short: Will enable
flake8-bugbearthat is a flake8 plugin to track even more stuff during code quality checks.Solve issue #966 (originally posted in #959 (comment)). This PR also include duplicate work from #959.
I also took the chance to group all the
repo_namegenerations in a single utility function in tests.