Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove local_files_only and use codebase_version instead of branches #734

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented Feb 15, 2025

What this does

Simplifies the use of the dataset by looking for files locally first, then pulling from the hub if needed. By setting the argument force_cache_sync=True, this behavior can be overridden and force syncing local files from the hub first.

Also eliminate the hub branch convention we used so far to determine the version of a dataset. The value from codebase_version in the info.json is now the single source of truth to determine with what version of LeRobot a dataset was created.

We will only use the main branch by default, but one can specify a branch or commit by using the new revision arg. If this revision is not available on the hub, the latest available version will be downloaded.

How it was tested

  • Fetching a v2.0 dataset on this branch (e.g. lerobot/pusht) correctly displays a warning:
image

@aliberts aliberts mentioned this pull request Feb 15, 2025
3 tasks
…_v2.1' into user/aliberts/2025_02_15_rm_local_files_only
@aliberts aliberts marked this pull request as ready for review February 15, 2025 14:55
@aliberts aliberts requested a review from Cadene February 15, 2025 14:55
Copy link
Collaborator

@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God's work

@aliberts aliberts merged commit fbf2f22 into user/aliberts/2025_02_10_dataset_v2.1 Feb 19, 2025
5 checks passed
@aliberts aliberts deleted the user/aliberts/2025_02_15_rm_local_files_only branch February 19, 2025 07:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants