Remove poetry.lock
#737
Merged
Remove poetry.lock
#737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliberts
added
⚙️ Infra/CI
Cadene
approved these changes
Feb 16, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Removes
poetry.lockfrom the repo.Adapts tests in CI which used this file to install dependencies from.
Use uv instead of poetry to install dependencies faster
Motivation
While having a dependencies lock file is very useful in some situations, it doesn't really make sense for a library such as this project.
It also impends on development workflow when merging/rebasing and having to resolve conflicts in this file (which is pointless because the lock file has to be regenerated anyway)
How it was tested
Testsworkflow time comparison before / after:It should be even faster when cache propagates on main