Skip to content

Nathan unify modelargs #609

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 35 commits into from
Apr 14, 2025
Merged

Nathan unify modelargs #609

merged 35 commits into from
Apr 14, 2025

Conversation

NathanHB
Copy link
Member

@NathanHB NathanHB commented Mar 10, 2025

  • removed override batch size and made it part of model config
  • remove env config, config should be part of env directly, no need to load it up
  • better loading of models
    • baseclass for model configs, allows parsing of model config through cli or config file.
    • Unified naming for model args, i.e. model_name
  • removed openai endpoint, we can just use litellm for this, same for TGI and inference endpoints we don't really need it and it's better to have one interface

unk_token="<unk>",
padding_side="left",
truncation_side="left",
)
except FileNotFoundError:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be needed as it is an issue with tokenizer version or config

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants