Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the scale parameter of the
Attention2d
unfused implementation (#2385).Two aspects were corrected:
q.size(-1) ** -0.5
, i.e the rsqrt of the number of queries / sequence length. This matches the default value oftorch.nn.functional.scaled_dot_product_attention
.torch.nn.functional.scaled_dot_product_attention
.Tests were added to check the new implementation against the fused one.