Remove parent/child tests in auto model tests #16653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
approved these changes
Apr 7, 2022
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the tests that checks whether models/configs/tokenizers are sorted in the auto mappings such that children classes are before parent classes. While it may have been necessary in the pasts for the
AutoXxxAPIs to work, this is not longer the case and this actually makes it harder on contributors to add new models.Also, in the future we could have a script like isort that enforces all those auto-mappings are alphabetically sorted.