TF: remove set_tensor_by_indices_to_value #16729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
No problem on my side but it looks like it was introduced by @patrickvonplaten in #15562 so pinging him here to make sure that's ok.
|
The documentation is not available anymore as the PR was closed or merged. |
|
@sgugger The last diff belongs to @patrickvonplaten, but because the function was moved (from here (link from the commit immediatly before it was moved)). Last time it was touched was 2 years ago 😅 |
patrickvonplaten
approved these changes
Apr 12, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes our TF
set_tensor_by_indices_to_valuefunction and replaces all its uses bytf.where. They are the same, but with a different input order -- removing it means one fewer function to test while making the code easier for TF users.