Adding support for array key in raw dictionnaries in ASR pipeline.
#16827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
| @@ -134,8 +134,7 @@ Audio files are automatically loaded and resampled when calling the `"audio"` co | |||
| Let's extract the raw waveform arrays of the first 4 samples and pass it as a list to the pipeline: | |||
|
|
|||
| ```py | |||
| >>> raw_audio_waveforms = [d["array"] for d in dataset[:4]["audio"]] | |||
| >>> speech_recognizer(raw_audio_waveforms) | |||
| >>> speech_recognizer(dataset[:4]["audio"]) | |||
There was a problem hiding this comment.
Nice! Could you update the es version as well?
patrickvonplaten
approved these changes
Apr 19, 2022
sgugger
approved these changes
Apr 19, 2022
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Narsil
added a commit
to Narsil/transformers
that referenced
this pull request
Apr 21, 2022
…uggingface#16827) * Adding support for `array` key in raw dictionnaries in ASR pipeline. * ES . * Update src/transformers/pipelines/automatic_speech_recognition.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Making it work by not popping `array` first. * Black 22.3 Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…uggingface#16827) * Adding support for `array` key in raw dictionnaries in ASR pipeline. * ES . * Update src/transformers/pipelines/automatic_speech_recognition.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Making it work by not popping `array` first. * Black 22.3 Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding support for
arraykey in raw dictionnaries in ASR pipeline.This means we can simplify the Quicktour example to look again a bit
more what the old
ffmpegexample looked like.Even simpler code might be enabled by
huggingface/datasets#4180
in the future. We could then remove the
[:4]which is currently necessary to preventloading a huge audio in RAM upfront.
Performance-wise the iterator also enables using stuff like
batch_sizeandnum_workersin thepipeline object to get optimal performance (this will only show real differences on GPU which is not
included in this quicktour)
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@patrickvonplaten
@sgugger