Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix multiproc metrics in no_trainer examples #16865

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix multiproc metrics in no_trainer examples #16865

merged 2 commits into from
Apr 20, 2022

Conversation

muellerzr
Copy link
Contributor

Fixes a bug in the no_trainer scripts involving metric evaluation

What does this add?

Fixes up the metric evaluation in most of the no_trainer scripts when multi-processing is involved. The final batch gets duplicated in those situations, so the metrics are slightly higher (or lower) than their actual values.

Who is it for?

Users of the no_trainer scripts

@muellerzr muellerzr added Examples Which is related to examples in general bug labels Apr 20, 2022
@muellerzr muellerzr requested a review from sgugger April 20, 2022 20:53
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 20, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nit to propagate across examples :-)
Thanks!

@muellerzr muellerzr merged commit 705d653 into main Apr 20, 2022
@muellerzr muellerzr deleted the fixup-examples branch April 20, 2022 21:26
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Examples Which is related to examples in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants