TF: XLA logits processors - minimum length, forced eos, and forced bos #16912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Rocketknight1
approved these changes
Apr 25, 2022
Comment on lines
+227
to
+228
| lambda: self._apply_eos_token_mask(scores), | ||
| lambda: tf.identity(scores), |
There was a problem hiding this comment.
Suggested change
| lambda: self._apply_eos_token_mask(scores), | |
| lambda: tf.identity(scores), | |
| self._apply_eos_token_mask(scores), | |
| scores, |
Would this work without the lambdas and identity call? I feel like it should but I'm not sure if I'm missing something obvious.
There was a problem hiding this comment.
Nope, it doesn't. Super unintuitive, but tf.cond expects a callable, not the output of each branch 😬 (docs)
It fails if we remove the lambda.
patrickvonplaten
approved these changes
Apr 25, 2022
Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
huggingface#16912) * XLA min len, forced eos, and forced bos Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Review after #16899)
A few more XLA-compatible logits processors -- minimum length, forced eos, and forced bos. Only the first one needed changes, mostly to avoid needless retracing (it actually compiled without changes but would trigger a retrace at iteration, which would be super slow).
After this PR, the only remaining processors are the bad words and ngrams ones.