Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix Iterations for decoder #16934

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix Iterations for decoder #16934

merged 1 commit into from
Apr 26, 2022

Conversation

agemagician
Copy link
Contributor

The current script works fine if the number of decoder layers = the number of encoder layers.
However, it will not work if the number of layers is not equal, like in t5-efficient models.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Models:

@agemagician
FIx Iterations for decoder
6c9fce8 
The current script works fine if the number of decoder layers = the number of encoder layers.
However, it will not work if the number of layers is not equal, like in t5-efficient models.

This script fixes this issue.
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 25, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

patil-suraj
patil-suraj approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@patil-suraj patil-suraj merged commit 8afaaa2 into huggingface:main Apr 26, 2022
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@agemagician @elusenji
FIx Iterations for decoder (huggingface#16934)
32ebd6f 
FIx Iterations for decoder
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@patil-suraj patil-suraj patil-suraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agemagician @HuggingFaceDocBuilderDev @patil-suraj