Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up vision tests #17024

Merged
merged 2 commits into from
May 2, 2022
Merged

Conversation

NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Apr 30, 2022

What does this PR do?

This is a follow-up of #16799. It took me way too long to realize I don't need to overwrite test_attention_outputs and test_hidden_states_outputs as I can just set the seq_length attribute of the ModelTester. 😂

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 30, 2022

The documentation is not available anymore as the PR was closed or merged.

@NielsRogge NielsRogge requested a review from ydshieh May 2, 2022 12:29
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this clean-up!
(as well as for the work on the TF/Flax files ❤️ )

BTW, we should still have at least one review from some core maintainers.

@@ -200,8 +198,8 @@ def setUp(self):
def test_config(self):
self.config_tester.run_common_tests()

@unittest.skip(reason="BEiT does not use inputs_embeds")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@NielsRogge NielsRogge requested a review from sgugger May 2, 2022 14:00
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup!

@NielsRogge NielsRogge merged commit 2de2c9e into huggingface:main May 2, 2022
nandwalritik pushed a commit to nandwalritik/transformers that referenced this pull request May 3, 2022
* Clean up tests

* Make fixup

Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request May 3, 2022
* Clean up tests

* Make fixup

Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
@NielsRogge NielsRogge mentioned this pull request May 23, 2022
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* Clean up tests

* Make fixup

Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants