-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Clean up vision tests #17024
Clean up vision tests #17024
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for this clean-up!
(as well as for the work on the TF/Flax files ❤️ )
BTW, we should still have at least one review from some core maintainers.
@@ -200,8 +198,8 @@ def setUp(self): | |||
def test_config(self): | |||
self.config_tester.run_common_tests() | |||
|
|||
@unittest.skip(reason="BEiT does not use inputs_embeds") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice cleanup!
* Clean up tests * Make fixup Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
* Clean up tests * Make fixup Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
* Clean up tests * Make fixup Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
What does this PR do?
This is a follow-up of #16799. It took me way too long to realize I don't need to overwrite
test_attention_outputs
andtest_hidden_states_outputs
as I can just set theseq_length
attribute of the ModelTester. 😂