Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix hashing for deduplication in CodeParrot #17048

Merged
merged 1 commit into from
May 4, 2022
Merged

Fix hashing for deduplication in CodeParrot #17048

merged 1 commit into from
May 4, 2022

Conversation

thomasw21
Copy link
Contributor

What does this PR do?

Fix hashing mechanism to be process independent. Typically hash doesn't generate the same hash when using different process. So this makes the maximum number of occurence of a text to be num_proc instead of 1 when deduplicating.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@lvwerra @loubnabnl

@thomasw21 thomasw21 requested a review from lvwerra May 2, 2022 15:47
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 2, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

lvwerra
lvwerra approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! ❤️

@lvwerra lvwerra merged commit db03466 into main May 4, 2022
@lvwerra lvwerra deleted the thomas/fix_hashing_for_deduplication branch May 4, 2022 06:40
nandwalritik pushed a commit to nandwalritik/transformers that referenced this pull request May 4, 2022
@thomasw21 @nandwalritik
Fix hashing for deduplication (huggingface#17048)
a86b7de
nandwalritik pushed a commit to nandwalritik/transformers that referenced this pull request May 4, 2022
@thomasw21 @nandwalritik
Fix hashing for deduplication (huggingface#17048)
f57a5a2
Narsil pushed a commit to Narsil/transformers that referenced this pull request May 12, 2022
@thomasw21 @Narsil
Fix hashing for deduplication (huggingface#17048)
f55f314
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@thomasw21 @elusenji
Fix hashing for deduplication (huggingface#17048)
998eff5
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lvwerra lvwerra lvwerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasw21 @HuggingFaceDocBuilderDev @lvwerra