Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix MLflowCallback end_run() and add support for tags and nested runs #17130

Merged
merged 6 commits into from
May 9, 2022
Merged

Fix MLflowCallback end_run() and add support for tags and nested runs #17130

merged 6 commits into from
May 9, 2022

Conversation

orieg
Copy link
Contributor

@orieg orieg commented May 8, 2022

What does this PR do?

This PR includes:

  • Add support for MLFLOW_TAGS, MLFLOW_RUN_ID, and MLFLOW_NESTED_RUN
  • ensure that MLflow runs that were started with on_train_begin() are also properly terminated when on_train_end() hook is called.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 8, 2022

The documentation is not available anymore as the PR was closed or merged.

@orieg orieg changed the title Fix mlflowcallback end run Fix MLflowCallback end_run() and add support for tags and nested runs May 8, 2022
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this!

src/transformers/integrations.py Outdated Show resolved Hide resolved
@sgugger sgugger merged commit 766d4bf into huggingface:main May 9, 2022
nandwalritik pushed a commit to nandwalritik/transformers that referenced this pull request May 10, 2022
…huggingface#17130)

* ensure mlflow.end_run() is executed at end of training when mlflow.start_run() was executed by the callback

* add debug msg

* add support for MLFLOW_TAGS, MLFLOW_RUN_ID, and MLFLOW_NESTED_RUN

* update to support python 3.6+

* Validate env variables using ENV_VARS_TRUE_VALUES

* Empty-Commit
Narsil pushed a commit to Narsil/transformers that referenced this pull request May 12, 2022
…huggingface#17130)

* ensure mlflow.end_run() is executed at end of training when mlflow.start_run() was executed by the callback

* add debug msg

* add support for MLFLOW_TAGS, MLFLOW_RUN_ID, and MLFLOW_NESTED_RUN

* update to support python 3.6+

* Validate env variables using ENV_VARS_TRUE_VALUES

* Empty-Commit
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
…huggingface#17130)

* ensure mlflow.end_run() is executed at end of training when mlflow.start_run() was executed by the callback

* add debug msg

* add support for MLFLOW_TAGS, MLFLOW_RUN_ID, and MLFLOW_NESTED_RUN

* update to support python 3.6+

* Validate env variables using ENV_VARS_TRUE_VALUES

* Empty-Commit
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants