-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Exllama kernels support for AWQ models #28634
Merged
ArthurZucker
merged 16 commits into
huggingface:main
from
IlyasMoutawwakil:awq-exllama-support
Mar 5, 2024
Merged
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c6528d3
added exllama kernels support for awq models
IlyasMoutawwakil 0ef397f
doc
IlyasMoutawwakil e20c192
style
IlyasMoutawwakil 78c03c1
Update src/transformers/modeling_utils.py
IlyasMoutawwakil 30cc4f6
refactor
IlyasMoutawwakil 76cbea1
moved exllama post init to after device dispatching
IlyasMoutawwakil df44597
bump autoawq version
IlyasMoutawwakil 6d8e4d5
Merge branch 'main' into awq-exllama-support
IlyasMoutawwakil 4d976b9
added exllama test
IlyasMoutawwakil 104c0f3
style
IlyasMoutawwakil 7944f04
configurable exllama kernels
IlyasMoutawwakil fdd5b2e
Merge branch 'main' into awq-exllama-support
IlyasMoutawwakil dd07fc3
copy exllama_config from gptq
IlyasMoutawwakil 10b093f
moved exllama version check to post init
IlyasMoutawwakil faa94d0
Merge branch 'main' into awq-exllama-support
IlyasMoutawwakil a7bb24a
moved to quantization dockerfile
IlyasMoutawwakil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't we make
max_input_len
configurable throughAwqConfig
- wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marc suggested we leave it as is for now #28634 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh okay ! I think it would makes sense to directly expose a
exllama_config
I think - wdyt @SunMarc ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would make more sense to expose it in a
exllama_config
!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in another PR right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I think it should be better to add it now and not leave the main branch with hardcoded config values, it shouldn't be super complex as you can just copy over the existing logic in GptqConfig right?