Fix: loading DBRX back from saved path #35728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zucchini-nlp
requested review from
Rocketknight1 and
ArthurZucker
as code owners
qgallouedec
approved these changes
Jan 16, 2025
ArthurZucker
approved these changes
Jan 24, 2025
|
Added a comment in existing test that the tiny model dtype is fp32, and we test by loading it with full and half precisions |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
pushed a commit
that referenced
this pull request
Jan 30, 2025
* fix dtype as dict for some models + add test * add comment in tests
bursteratom
pushed a commit
to bursteratom/transformers
that referenced
this pull request
Jan 31, 2025
* fix dtype as dict for some models + add test * add comment in tests
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes huggingface/trl#2574 and adds a test for that. Plus fixes one edge case when the composite model is loaded with
torch_dtype=torch.float16(i.e. the dtype is not string or dict) by adding one small condition