Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #1863 validation issue with schedule names #1864

Merged
merged 2 commits into from
Jan 8, 2017
Merged

Conversation

cantino
Copy link
Member

@cantino cantino commented Jan 8, 2017

Thanks for reporting this @JamiePhonic!

@cantino
Copy link
Member Author

cantino commented Jan 8, 2017

@dsander There were validation errors when comparing the OpenStruct to a string, so I went this direction instead.

Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn I should have checked that, looks good to me and thanks for fixing it!

@cantino
Copy link
Member Author

cantino commented Jan 8, 2017

No problem!

@cantino cantino merged commit 3ea44cb into master Jan 8, 2017
@cantino cantino deleted the fix_schedule_naming branch January 8, 2017 16:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants