Remove support for the Weather Underground API #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tantalum
changed the title
|
Thanks! We have to wait until the end of the year before we merge this, because the API stays online until then. |
|
Wunderground moved the shutdown date to the 15th of Feb, which was yesterday, but for some reason my WeatherAgent is still working ¯_(ツ)_/¯ |
dsander
reviewed
Mar 10, 2019
|
The API doesn't work anymore after 5th of March. Please remove the code and maybe even add a better alternative like openweathermap.org. |
dsander
requested changes
Aug 3, 2019
dsander
approved these changes
Aug 12, 2019
knu
approved these changes
Aug 13, 2019
app/models/agents/weather_agent.rb
Outdated
| @@ -135,22 +117,12 @@ def validate_location | |||
| end | |||
|
|
|||
| def validate_options | |||
| errors.add(:base, "service must be set to 'darksky' or 'wunderground'") unless wunderground? || dark_sky? | |||
| errors.add(:base, "The Weather Underground API has been disables since Jan 1st 2018, please switch to DarkSky") if wunderground? | |||
There was a problem hiding this comment.
There's a trivial typo disables and maybe the date should be updated.
There was a problem hiding this comment.
Good cach ;-). I just pushed an update
|
I think that should be "disabled", not "disables". |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the Weather Underground API to resolve #2391