Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

persist override of HUGINN_PORT #2448

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

oskapt
Copy link
Contributor

@oskapt oskapt commented Jan 2, 2019

fixes #2447

@dsander
Copy link
Collaborator

dsander commented Jan 5, 2019

Those legacy HUGINN_ prefixes keep biting us 😒

I think your solution should not break any other use case of the variables.

@baip Could you please double check that I am not missing something?

@baip
Copy link
Contributor

baip commented Jan 7, 2019

I don't think it should affect anything else either. It's funny that I added the awk treatment specifically to handle Kubernetes where the container is named huginn but my later PR to clean up how .env is formed introduced this regression. My apologies!

@dsander
Copy link
Collaborator

dsander commented Jan 7, 2019

@baip Thanks for double checking! There are simply too many possible configurations to remember all edge cases 😄 I added a test to the https://github.com/huginn/huginn_docker_specs repository.

@oskapt Thanks for the detailed description in the issue and the fix!

@dsander dsander merged commit 7ca39eb into huginn:master Jan 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup_env picks up HUGINN_PORT and doesn't persist override of value
3 participants