Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve #2434 (Add HTTP Headers to Webhook Agent) #2454

Merged
merged 3 commits into from
Jan 8, 2019

Conversation

knu
Copy link
Member

@knu knu commented Jan 6, 2019

This PR is based on and adds some improvements to #2434. Here's a list of what I've done:

  • Use the real header names instead of those in the HTTP_FOO_BAR format
  • Extract a logic for including a header hash in event payloads from PostAgent, with the event_headers_style option
  • Rename headers to event_headers (and accept an array of strings also)
  • Rename header_key to event_headers_key
  • Introduce EventHeadersConcern which implements all above to be shared among PostAgent and WebhookAgent
    • I'm also working on making ImapAgent use it to add email headers to its event payloads.
  • Squash the commits into one removing file mode changes and whitespace diffs

/cc @Fishwaldo

@Fishwaldo
Copy link
Contributor

looks good to me

@knu knu force-pushed the add_http_headers_to_webhook_agent branch from a2942b6 to e668dbe Compare January 7, 2019 11:17
@knu knu requested a review from dsander January 7, 2019 12:09
Copy link
Collaborator

@dsander dsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me 👍

@knu
Copy link
Member Author

knu commented Jan 8, 2019

Thanks!

@knu knu merged commit e668dbe into master Jan 8, 2019
@knu knu deleted the add_http_headers_to_webhook_agent branch January 8, 2019 03:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants